search

cloudflare / cloudflare-ingress-controller

A Kubernetes ingress controller for Cloudflare's Argo Tunnels
Apache License 2.0
364 stars 55 forks source link

expands default secret mapping to wildcards #151

Closed mattalberts closed 5 years ago

mattalberts commented 5 years ago

Expands host definitions allowed by origin-secret-config. Wildcard hosts of the form ".domain" and "" are now allowed. When a wildcard conflicts with a specific host, the specific mapping takes precedence. If both "*" and default-origin-secret are specified, default-origin-secret takes precedence.

resolves #126

codecov-io commented 5 years ago

Codecov Report

Merging #151 into master will increase coverage by 0.95%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   60.27%   61.23%   +0.95%     
==========================================
  Files          17       17              
  Lines        1173     1202      +29     
==========================================
+ Hits          707      736      +29     
- Misses        444      445       +1     
+ Partials       22       21       -1
Impacted Files Coverage Δ
cmd/argot/main.go 5.44% <0%> (ø) :arrow_up:
internal/argotunnel/translator.go 61.88% <0%> (-0.62%) :arrow_down:
internal/argotunnel/options.go 100% <100%> (ø) :arrow_up:
internal/cloudflare/originsecret.go 100% <100%> (+6.89%) :arrow_up:
internal/argotunnel/informer.go 58.69% <78.57%> (+3.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f6acac...745d12d. Read the comment docs.