codecov-io
commented
5 years ago Codecov Report
:exclamation: No coverage uploaded for pull request base (
0.6.x@cf24e97). Click here to learn what that means. The diff coverage is38.79%.
@@ Coverage Diff @@
## 0.6.x #92 +/- ##
========================================
Coverage ? 39.81%
========================================
Files ? 15
Lines ? 884
Branches ? 0
========================================
Hits ? 352
Misses ? 517
Partials ? 15| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/argotunnel/metrics.go | 0% <ø> (ø) |
|
| internal/argotunnel/controller.go | 0% <0%> (ø) |
|
| cmd/argot/main.go | 11.26% <0%> (ø) |
|
| internal/argotunnel/version.go | 0% <0%> (ø) |
|
| internal/argotunnel/worker.go | 0% <0%> (ø) |
|
| internal/argotunnel/options.go | 100% <100%> (ø) |
|
| internal/k8s/audit.go | 100% <100%> (ø) |
|
| internal/argotunnel/annotations.go | 100% <100%> (ø) |
|
| internal/k8s/types.go | 78.94% <100%> (ø) |
|
| internal/cloudflare/origincert.go | 100% <100%> (ø) |
|
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update cf24e97...a62f6ab. Read the comment docs.
The change is braking from 0.5.x. Resource and resource relationshipd are not handled more similarly to other ingress controllers. Secrets are no longer linked by label. A secret relationship is linked to a hostname using the ingress definition. Though using a tunnel pem origin cert by reference under the tls section feels awkward, the tunnel does setup tls for free, and it provides the most natural pairing without introduction of a CRD. Ingress definitions may now contain multiple hosts and rules (there is no longer a restriction of a single host/rule per-ingress). Path based routing is still not available, the field is ignored.