cloudflare / cloudflare-php

PHP library for the Cloudflare v4 API
BSD 3-Clause "New" or "Revised" License
621 stars 222 forks source link

Ignoring guzzle http errors #148

Closed kgrzelak closed 3 years ago

kgrzelak commented 4 years ago

If cloudflare api returns http code other than 2xx we get a guzzlehttp exception, the checkError function will not be able to execute before the exception

jacobbednarz commented 3 years ago

sorry for the delay here but this is intentional as non-200's should be explictly handled with something like a try/catch. i can't see any good reason at the moment to change this.