search

cloudflare / cloudflare-php

PHP library for the Cloudflare v4 API
BSD 3-Clause "New" or "Revised" License
621 stars 222 forks source link

Add Missing Support For Custom Hostname Properties #178

Closed phily245 closed 3 years ago

phily245 commented 3 years ago

As mentioned in #177, there are some missing properties from custom hostname creation (shown at https://api.cloudflare.com/#custom-hostname-for-a-zone-create-custom-hostname). This PR attempts to add these in.

Closes #177

phily245 commented 3 years ago

I used TDD on this so I haven't tested yet, but I suspect the options are in the wrong place according to the docs.

I'll fix this tomorrow.

phily245 commented 3 years ago

I used TDD on this so I haven't tested yet, but I suspect the options are in the wrong place according to the docs.

I'll fix this tomorrow.

I was right, testing this on live proved that not only my options were at the wrong level, but the wildcard flag was too (as they're all the same level in the docs). I've pushed a fix for this

jacobbednarz commented 3 years ago

I'm happy to review these PRs you've raised if you fix those lint failures in CI

phily245 commented 3 years ago

I'm happy to review these PRs you've raised if you fix those lint failures in CI

Thank you, I can look at this today :smile:

phily245 commented 3 years ago

@jacobbednarz the failing lint has been addressed

jacobbednarz commented 3 years ago

awesome, thanks! 👏