search

cloudflare / cloudflare-php

PHP library for the Cloudflare v4 API
BSD 3-Clause "New" or "Revised" License
621 stars 222 forks source link

Missing Support For Custom Hostname Update Properties #180

Closed phily245 closed 3 years ago

phily245 commented 3 years ago

As mentioned in #179, there are some missing properties from custom hostname creation (shown at https://api.cloudflare.com/#custom-hostname-for-a-zone-edit-custom-hostname). This PR attempts to add these in.

Closes #179

jacobbednarz commented 3 years ago

similar to your other PR, the lint failures will need addressing here.

phily245 commented 3 years ago

@jacobbednarz the failing lint has been sorted here too, it took a bit longer because the pipeline was randomly failing to pull from dockerhub for some reason.

phily245 commented 3 years ago

@jacobbednarz the failing lint has been sorted here too, it took a bit longer because the pipeline was randomly failing to pull from dockerhub for some reason.

E.g. https://github.com/cloudflare/cloudflare-php/runs/2884256252?check_suite_focus=true

jacobbednarz commented 3 years ago

Thanking you! 👏