search

cloudflare / cloudflare-php

PHP library for the Cloudflare v4 API
BSD 3-Clause "New" or "Revised" License
621 stars 222 forks source link

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #73

Closed samnela closed 5 years ago

owenvoke commented 6 years ago

I feel like this would be a great idea, but it looks like it would be incompatible with the PHPUnit version that is being used by this library. It's currently hardcoded to use PHPUnit v5.7.5 specifically which doesn't have the newer TestCase class.

See: https://github.com/sebastianbergmann/phpunit/blob/5.7.5/src/Framework/TestCase.php

The new TestCase class was added in PHPUnit v6.0.0 and later.

samnela commented 5 years ago

The forward compatibility was added in PHPUnit 4.8.35, this is why the Travis CI build passed

owenvoke commented 5 years ago

Thanks for informing me, not sure why I didn't check the rest of the src directory. :+1: That's good then.

Would probably be nice to update PHPUnit anyway.