search

cloudflare / cloudflare-php

PHP library for the Cloudflare v4 API
BSD 3-Clause "New" or "Revised" License
621 stars 222 forks source link

Is there a method to delete and existing zone? I found none. #86

Open bluerid opened 5 years ago

bluerid commented 5 years ago

Is there a method that implements the functionality of this cloudflare api endpoint? I found a method deleteHostname but that's for custom hostnames that are routed via CNAME.

aaronhuisinga commented 5 years ago

There currently is no method for deleting an existing zone. There actually seems to be numerous missing methods that exist in the official API.

bluerid commented 5 years ago

@IcyApril I have created a deleteZone method in zone endponts in a feature branch. Should i push and create pull request?

bluerid commented 5 years ago

@IcyApril Could you please review this issue?

IcyApril commented 5 years ago

@bluerid Sorry for the slow reply - please do create a PR! Tests and passing of the CI tests (PHPMD) is what's usually needed (if you haven't already done so).

beltofte commented 5 years ago

PR https://github.com/cloudflare/cloudflare-php/pull/99