search

cloudflare / cloudflared

Cloudflare Tunnel client (formerly Argo Tunnel)
https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/install-and-setup/tunnel-guide
Apache License 2.0
9.2k stars 811 forks source link

Add `--no-daemon` or `--foreground` option for supervised systems #315

Open jac-cbi opened 3 years ago

jac-cbi commented 3 years ago

I've recently moved most of my servers and VMs to Artix Linux (a derivative of Arch Linux, sans systemd). I chose the runit system for my init and process supervision system on my Artix boxes (s6 is a mess, and OpenRC, well, it's not a supervision system). This has been working great up until I attempted to move my web server from Gentoo to Artix. Everything went smoothly, except for cloudflared.

I use cloudflared for connecting to the Cloudflare network, which caches, and serves my websites. It's a traditional use of Argo tunnel, namely, my web server is not accessible from the Internet, only from CF via Argo tunnel.

Basically, If CF were to add a --no-daemon option, this would allow me to launch the process in a supervised manner, meaning that there is a parent process which receives SIGCHLD and can automatically restart the dead process. Additionally, this means I could allow cloudflared to automagically update itself, and once complete, it can just exit. No races, no PID tracking, and more importantly, no dropped log messages. (runit handles that).

stevenanthonyrevo commented 3 years ago

Upvote for including this, PID tracking is a pain.

andrewheberle commented 3 years ago

I must be missing something here...but cloudflared has always run in the foreground and runs fine under a supervision system in my experience...

jac-cbi commented 3 years ago

@andrewheberle Could you provide some more detail? What OS/distro/arch are you running on? What is the command line used to launch cloudflared?

septatrix commented 2 years ago

I am running cloudflared on Fedora 35 and installed it with the rpm package from the release page. On my system it runs in the foreground. Despite that I can only say that the Dockerfile and systemd service explicitly specify --no-autoupdate so maybe that flag is responsible for making it detach? Also --pidfile did nothing (trying to maybe force detaching) so I am not sure why you are seemingly experiencing something different.