search

cloudflare / embed-box

Universal install guide for embed codes and CMS plugins.
http://embedbox.io
MIT License
78 stars 12 forks source link

Add collapse button to embedCode container #107

Closed GirlBossRush closed 8 years ago

GirlBossRush commented 8 years ago

Multi-line embed codes can consume a lot of vertical space. We can display the copy container as one line, and truncate the embed code in the examples.

GirlBossRush commented 8 years ago

Given our discussion yesterday. I've update the ticket.

Cheers

adamschwartz commented 8 years ago

Moved to https://github.com/EagerIO/EmbedBox/issues/120 since this was for the copy containers, not the screenshots. The copy containers should still optionally allow visibility into what you’re copying.

adamschwartz commented 8 years ago

https://github.com/EagerIO/EmbedBox/pull/113/commits/79aff7b25409c2b343d4083a6b41e8c817f9e5bd

adamschwartz commented 8 years ago

image

GirlBossRush commented 8 years ago

@adamschwartz, Awesome collapse button!

The copy button feels a odd fitting, more suited for a download button. What are your thoughts on this concept? https://gist.github.com/TeffenEllis/e9b50fb5b2e7352fc18118e8316cbdd4

A less ornamental version could fit our theme quite well. The arrow pointing into a clipboard is a strong symbol.

Cheers

On Thu, Sep 15, 2016 at 11:45 PM, Adam Schwartz notifications@github.com wrote:

[image: image] https://cloud.githubusercontent.com/assets/154613/18577431/abc7adbe-7bb7-11e6-866d-37bd5716a6e0.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EagerIO/EmbedBox/issues/107#issuecomment-247529881, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkJBqyWEuX-sQx-7DsOYZ9shNMgWUq-ks5qqjsegaJpZM4J5mmP .

Teffen Ellis Product Engineer @TeffenEllis https://twitter.com/TeffenEllis

adamschwartz commented 8 years ago

Thanks! Glad you like the collapse button.

Please make a mock with an icon in place. I tried that very icon as well as a few others and struggled to get them to look clear when in the actual button.