search

cloudflare / embed-box

Universal install guide for embed codes and CMS plugins.
http://embedbox.io
MIT License
78 stars 12 forks source link

Handle default inline mode styling better #108

Closed adamschwartz closed 8 years ago

adamschwartz commented 8 years ago

After seeing https://eager.io/blog/introducing-embedbox-open-source-embed-code-ui/ I did some hunting in the code and left this comment: https://github.com/EagerIO/EmbedBox/commit/a30955cfa7b01319381557e72fc9dfafb0af7479#commitcomment-18974686. Let’s think about this more broadly though.

adamschwartz commented 8 years ago

cc @TeffenEllis

adamschwartz commented 8 years ago

I also think the inline version kind of makes no sense on small screens, so I suggested to @zackbloom that in the blog post we display the inline one for our desktop breakpoint, and then show a button to launch a modal for our mobile breakpoint. But I’m wondering now if perhaps this should be something offered by the library itself? I suppose it would be pretty easy to implement on the blog without EmbedBox offering a more direct way to do this, but one potential advantage of having the library do it is handling the responsive switch (if someone resizes a browser) and applying a nice default styling (using the accentColor, e.g.) to the button we show to launch the modal on mobile.

If we think this is worthwhile I can make a separate issue for it. But for now let’s discuss inline-mode-related enhancements/options here.

GirlBossRush commented 8 years ago

Status update,

Master includes better default alignment and styles when in inline mode.

adamschwartz commented 8 years ago

https://github.com/EagerIO/EmbedBox/commit/977d8b75fda86a007996944c81f6e1d0e1ea328b