cloudflare / embed-box

Universal install guide for embed codes and CMS plugins.
http://embedbox.io
MIT License
78 stars 12 forks source link

Notion of embed-code-only targets #55

Closed adamschwartz closed 8 years ago

adamschwartz commented 8 years ago

@TeffenEllis maybe this is already a thing and I just don’t know how it works, but I think we need a way of saying a target only supports an embed code, and has no plugin system. I suppose we might also want the opposite, but in practice I don’t think that’s very common.

The idea then would be that once an embed code were provided in the configuration, we would either error and/[or (silently)] hide the plugin from the list of targets.

GirlBossRush commented 8 years ago

@adamschwartz,

I've added a few checks during target creation that validate whether or not rendering is possible with the given options. Internally targets have a policy on whether they're built for plugins, embed codes, or both.

This is documented now too! http://embedbox.io/#downloads

Let me know if there's any gaps in the render logic 🐳 Cheers