search

cloudflare / embed-box

Universal install guide for embed codes and CMS plugins.
http://embedbox.io
MIT License
77 stars 12 forks source link

Regression: Enter no longer submits target list selection when search input is blurred #66

Closed adamschwartz closed 8 years ago

adamschwartz commented 8 years ago

Repro:

  1. Visit http://embedbox.io
  2. Click into demo.
  3. Click WordPress.
  4. Hit Enter.
GirlBossRush commented 8 years ago

@adamschwartz,

This was introduced in the accessibility changes. https://github.com/EagerIO/EmbedBox/commit/00781037979a6e38e87e530faedbbdf012ae60d1#diff-219ac9083f78b0aa72db25c0306c5af1R168

The input field uses the arrow keys to select targets, then enter navigates to the target instructions

In the tab key flow, tabbing focuses through each targets. Then enter or spacebar is used to select an entry. The user must tab down to the "Next" button to navigate.

I believe limiting selection to the spacebar can make both concepts align to the user's expectations.

Thoughts?

adamschwartz commented 8 years ago

I liked the speed of it the other way, but this argument makes sense to me. I’ll leave it up to you! 👍