search

cloudflare / embed-box

Universal install guide for embed codes and CMS plugins.
http://embedbox.io
MIT License
78 stars 12 forks source link

Force iOS Safari bar to show on navigation into target #77

Closed adamschwartz closed 8 years ago

adamschwartz commented 8 years ago

When navigating into a target, if the iOS Safari bottom toolbar is visible, then the bottom of the instructions are unreadable. Scrolling the instructions doesn’t cause the bottom toolbar to fade away presumably because that scrolling is not taking propagated up. The only way I’ve found to get the toolbar to hide (and thus reveal the bottom of the instructions) is to attempt to drag up on the modal header. This is certainly annoying and non-obvious so we should figure out a solution. My proposition here is to force the bar to show somehow. Alternatively if we cannot do that we can place some reserved space below the scrolling area.

cc @TeffenEllis

GirlBossRush commented 8 years ago

Resolved in a5d4759 with additional padding in scrollable elements.

adamschwartz commented 8 years ago

👍 we’ll need to scope this better (see https://github.com/EagerIO/EmbedBox/commit/a5d47599072bce5e225c4480fca6892a25a68f08#commitcomment-18858137) but nice job!