There are several separate specific issues with the new implementation of data-intrinsic for https://github.com/EagerIO/EmbedBox/issues/73. I think it will be most helpful to try to illuminate them with a simple example:
This is on the site:
But this is closer to how it should actually look:
Now I’ll do my best to point out what are some of the specific issues I’ve seen in the code:
The intrinsic ratio isn’t honored. A figure can specify an intrinsic ratio of 0.5 and then not present with that ratio. (The example above demonstrates this.)
1000px is improperly used as the width of iframes whose contents are less wide then that. (The example above demonstrates this.)
The new .shield is unnecessary. (That was only used in the gist/jsfiddle mock to make a coherent/complete demo. We already have this.)
The intrinsic spacer is implemented as a class name but the intrinsic wrapper is implemented as a data-attribute. As that was core to the mock, they were implemented both as data- attrs intentionally.
@TeffenEllis please let me know if any of this is confusing or needs further clarification.
There are several separate specific issues with the new implementation of
data-intrinsicfor https://github.com/EagerIO/EmbedBox/issues/73. I think it will be most helpful to try to illuminate them with a simple example:This is on the site:
But this is closer to how it should actually look:
Now I’ll do my best to point out what are some of the specific issues I’ve seen in the code:
figurecan specify an intrinsic ratio of0.5and then not present with that ratio. (The example above demonstrates this.)1000pxis improperly used as the width of iframes whose contents are less wide then that. (The example above demonstrates this.).shieldis unnecessary. (That was only used in the gist/jsfiddle mock to make a coherent/complete demo. We already have this.)data-attrs intentionally.@TeffenEllis please let me know if any of this is confusing or needs further clarification.