cloudflare / foundations

Cloudflare's Rust service foundations library.
https://blog.cloudflare.com/introducing-foundations-our-open-source-rust-service-foundation-library
BSD 3-Clause "New" or "Revised" License
1.25k stars 50 forks source link

span_fn should add tag error=true for functions returning Result when is_err is true #31

Open toffaletti opened 6 months ago

toffaletti commented 6 months ago

It would be nice to automatically get error tags, which jaeger and other frontends have special ui treatment for.

evanrittenhouse commented 1 month ago

You can assign this to me, it'd be nice to have for some stuff we're working on. I'll have to figure out how to handle the case where an error tag is already added. For now I think it's fine to just exclude it if the tag has it