search

cloudflare / foundations

Cloudflare's Rust service foundations library.
https://blog.cloudflare.com/introducing-foundations-our-open-source-rust-service-foundation-library
BSD 3-Clause "New" or "Revised" License
1.25k stars 51 forks source link

Release 3.4.0 #48

Closed bcottrell8738 closed 2 months ago

bcottrell8738 commented 3 months ago

My motivation for proposing a release is that I would like to get https://github.com/cloudflare/foundations/pull/47

I was figuring a "minor" bump for that, but I'm open to different viewpoints.

nmldiegues commented 3 months ago

Clippy isn't happy

bcottrell8738 commented 3 months ago

Can we run cargo-semver-checks to determine the level of breaking changes? Since we don't track manually what's breaking or not, it's hard to tell from the RELEASE_NOTES.

cargo semver-checks says it needs to be a major version (!) -- I don't know if that also means we want more coordination around the timing of this. I was just hoping to get my change in there, but maybe my change should take a back seat.

fisherdarling commented 3 months ago

Can we run cargo-semver-checks to determine the level of breaking changes? Since we don't track manually what's breaking or not, it's hard to tell from the RELEASE_NOTES.

cargo semver-checks says it needs to be a major version (!) -- I don't know if that also means we want more coordination around the timing of this. I was just hoping to get my change in there, but maybe my change should take a back seat.

Like it's suggesting 4.0.0? That's fine! Whatever the semver gods require.