Closed simPod closed 4 years ago
LGTM. Thank you for writing the test :) .
Sorry I've been taking too long at verifying this PR.
Are you sure you want to share a real sFlow sample? I'm noticing a few ip addresses in there that don't seem to be obfuscated.
I merged two flow samples into one so it should not represent real communication. Do you think it is not safe still?
I'd be careful in case of an audit: non-obfuscated PII (even if long ago) since it's the full sFlow packet. Would prefer not have to clear the whole git history if that were to cause an issue.
I have been debugging expanded sflow parsing and for that I wrote these 2 tests.
(I was not sure it was being parsed properly. The error in the end was in reading prometheus metrics (wrong label filter) so everything in goflow works as expected)
I though might share rather than removing it, WDYT?