Closed mmlb closed 4 years ago
Thanks for the PR @mmlb!
I can get rid of the tag v1 but cannot find much doc on the behavior of go get
which would fetch directly v1.
This seems to describe the go.mod with vXX.
Will take a look why the build fails.
So I think it might be because all of the goflow code also imports itself @v1? I think the bit about sed ...
illustrates that. I'm not a fan of the vN
subdirs and thought that might not be required, but might be wrong.
@lspgn I think I've figured out the test failures. Without the import path re-write like shown in the page you linked the repo was in a weird mixed version mode I think. When I ran make race-test
locally it failed just like in travis. With the import path re-written to have the version in it, tests now pass locally. Lets see if its true in travis too.
Tests are green :tada:
I can get rid of the tag v1 but cannot find much doc on the behavior of
go get
which would fetch directly v1.
You don't want to do that, that could break other users.
ping @lspgn tests are green now, anything else before merge?
Without this change
go get
in module mode (andgo mod
commands) fail since go is fetching/importing the latest v1 release. Its nice that v1 fails to build because of import path requirement that brings this issue to light.Which is the case in v1.1.0 tag.