Remove remote_port label from flow_traffic metrics

cloudflare / goflow

The high-scalability sFlow/NetFlow/IPFIX collector used internally at Cloudflare.

BSD 3-Clause "New" or "Revised" License

852 stars 171 forks source link

Remove remote_port label from flow_traffic metrics #95

Open slrtbtfs opened 3 years ago

slrtbtfs commented 3 years ago

Fixes #94.

However it theoretically has the potential to break some existing usecases, where the distiction between remote ports is relevant.

Signed-off-by: Tobias Guggenmos tobias.guggenmos@uni-ulm.de

debugloop commented 3 years ago

I was a bit alarmed by this, but the IOS-XR flow export we use does not randomize the source port regularly, may be even only on chassis reload. Still, this seems like a good precaution, I don't really see what you'd use that label for.

SuperQ commented 3 years ago

Ping @lspgn. :smile: Any chance we can get some reviews and a release?

lspgn commented 3 years ago

Hello, Thank you for the PR, looks good to me. But I won't be able to merge yet (see #97). Thank you for your patience.