search

cloudflare / hellogopher

Hellogopher: "just clone and make" your conventional Go project
MIT License
1.15k stars 59 forks source link

log15 : Seem something goes wrong #1

Closed jerome-laforge closed 7 years ago

jerome-laforge commented 7 years ago

Hello, I try hellogopher with log15.

$ cd /tmp/

$ git clone https://github.com/inconshreveable/log15.git

$ cd log15

$ wget https://raw.githubusercontent.com/cloudflare/hellogopher/master/Makefile

$ vim Makefile # for setting the IMPORT_PATH like this: IMPORT_PATH := github.com/inconshreveable/log15

$ make setup
go get -u github.com/FiloSottile/gvt
./bin/gvt fetch golang.org/x/tools/cmd/goimports
2017/01/21 12:28:36 Fetching: golang.org/x/tools/cmd/goimports
2017/01/21 12:28:37 · Fetching recursive dependency: golang.org/x/tools/imports
2017/01/21 12:28:37 ·· Fetching recursive dependency: golang.org/x/tools/go/ast/astutil
./bin/gvt fetch github.com/wadey/gocovmerge
2017/01/21 12:28:37 Fetching: github.com/wadey/gocovmerge
2017/01/21 12:28:38 · Fetching recursive dependency: golang.org/x/tools/cover

$ make
.GOPATH/src/github.com/inconshreveable/log15/handler.go:11:2: cannot find package "github.com/go-stack/stack" in any of:
        /tmp/test/log15/.GOPATH/src/github.com/inconshreveable/log15/vendor/github.com/go-stack/stack (vendor tree)
        /usr/lib/go/src/github.com/go-stack/stack (from $GOROOT)
        /tmp/test/log15/.GOPATH/src/github.com/go-stack/stack (from $GOPATH)
.GOPATH/src/github.com/inconshreveable/log15/root.go:7:2: cannot find package "github.com/mattn/go-colorable" in any of:
        /tmp/test/log15/.GOPATH/src/github.com/inconshreveable/log15/vendor/github.com/mattn/go-colorable (vendor tree)
        /usr/lib/go/src/github.com/mattn/go-colorable (from $GOROOT)
        /tmp/test/log15/.GOPATH/src/github.com/mattn/go-colorable (from $GOPATH)

Do I miss something? Thx in adv

FiloSottile commented 7 years ago

Thank you for your feedback! This should be addressed by the following suggestion:

If you get cannot find package errors, you need to read the Vendoring section.

https://github.com/cloudflare/hellogopher#vendoring

Let me know if that helps you figure it out. (Sorry for not being more helpful, I want to know if the docs can speak for themselves.) Feel free to comment if it doesn't.

Also opened #2 to make this more helpful.

jerome-laforge commented 7 years ago

Great, that's fixed my issue. Thx again!