cloudflare / homebrew-cloudflare

99 stars 41 forks source link

Error on Intel mac and M1 mac unable to install http3 curl #69

Closed thestarrypage closed 1 year ago

thestarrypage commented 1 year ago

I am facing this error on both my old intel mac and new m1 mac..is there anything wrong with the installation package?

==> cargo build --release --package=quiche --features=ffi,pkg-config-meta,qlog
==> ./buildconf
==> ./configure --disable-silent-rules --with-ssl=/private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src --with
==> make install
Last 15 lines from /Users/MYUSER/Library/Logs/Homebrew/curl/04.make:
vquic/curl_quiche.c:1645:24: error: no member named 'peer_max_idle_timeout' in 'quiche_stats'
      idle_ms = qstats.peer_max_idle_timeout;
                ~~~~~~ ^
3 errors generated.
make[1]: *** [vquic/libcurl_la-curl_quiche.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vssh/libssh.c -o vssh/libcurl_la-libssh.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vtls/vtls.c -o vtls/libcurl_la-vtls.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vtls/x509asn1.c -o vtls/libcurl_la-x509asn1.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vquic/vquic.c -o vquic/libcurl_la-vquic.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vssh/wolfssh.c -o vssh/libcurl_la-wolfssh.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vtls/openssl.c -o vtls/libcurl_la-openssl.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vtls/sectransp.c -o vtls/libcurl_la-sectransp.o >/dev/null 2>&1
libtool: compile:  clang -DHAVE_CONFIG_H -I../include -I../lib -I../lib -DBUILDING_LIBCURL -DCURL_HIDDEN_SYMBOLS -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/deps/boringssl/src/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/libssh2/1.11.0_1/include -isystem /usr/local/Cellar/openssl@3/3.1.3/include -isystem /usr/local/Cellar/rtmpdump/2.4-20151223_3/include -isystem /usr/local/Cellar/libidn2/2.3.4_1/include -isystem /usr/local/Cellar/libnghttp2/1.57.0/include -isystem /private/tmp/curl-20231022-37853-1scfqyu/quiche/quiche/include -fvisibility=hidden -Qunused-arguments -O2 -Wno-pointer-bool-conversion -Werror=partial-availability -c vssh/libssh2.c -o vssh/libcurl_la-libssh2.o >/dev/null 2>&1
make: *** [install-recursive] Error 1

Do not report this issue to Homebrew/brew or Homebrew/homebrew-core!

curl's formula was built from an unstable upstream --HEAD.
This build failure is expected behaviour.
Do not create issues about this on Homebrew's GitHub repositories.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.
jacobbednarz commented 1 year ago

cc @junhochoi in case you've come across this before

jacobbednarz commented 1 year ago

also, it looks like you are using HEAD to build here. what happens if you use the stable formula instead?

junhochoi commented 1 year ago

Looks like you used --HEAD. Can you try brew install -s ./curl.rb, without --HEAD? It works for me with curl 8.4.0 release. And it looks like https://github.com/curl/curl/commit/9cc57875777eacbb514bcc741350393999e14eca (added after 8.4.0 release) is breaking with new quiche API change (https://github.com/cloudflare/quiche/commit/ab2b44fa9b8b0f82d6604cb5693447deaf07dfdc). Need a fix from curl.

junhochoi commented 1 year ago

I opened https://github.com/curl/curl/pull/12180 In the meantime, please use 8.4.0 release (no --HEAD option)

jacobbednarz commented 1 year ago

thanks for confirming @junhochoi! closing as this is working as expected from the formula side.