search

cloudflare / keyless

Cloudflare's Keyless SSL Server Reference Implementation
Other
276 stars 78 forks source link

Makefile requires source to be a git checkout #44

Closed mrvacbob closed 10 years ago

mrvacbob commented 10 years ago

I'd like to avoid installing git on this machine, but keyserver won't build if you download a checkout as a zip from Github, rather than doing a git checkout. It would be nice if that could be supported

# gmake
fatal: Not a git repository (or any parent up to mount point /usr)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
date: illegal option -- -
usage: date [-jnu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ... 
            [-f fmt date | [[[[[cc]yy]mm]dd]HH]MM[.ss]] [+format]
gmake: *** [tmp/libuv-1daff47ae9df55902f07d3c5b8a3a393306a2f1e/.f] Error 5
jgrahamc commented 10 years ago

There are two problems here caused by these two lines:

REVISION  := $(shell git log -n1 --pretty=format:%h)
TODAY     := $(shell date --iso-8601=minutes --utc)

We are assuming that GNU date is available and we are assuming that we are in a git repository to get the commit hash.

jgrahamc commented 10 years ago

Fixed.