search

cloudflare / keyless

Cloudflare's Keyless SSL Server Reference Implementation
Other
276 stars 78 forks source link

Updated cipher suites, adding ECDSA support. Generated separate testing Keyserver/Keyless CAs #70

Closed 0xhaven closed 10 years ago

0xhaven commented 10 years ago

Set available ciphers to just ECDHE-ECDSA-AES256-GCM-SHA384 and ECDHE-RSA-AES256-GCM-SHA384, removing --cipher-list command line argument. Enabled use of ECDSA with curve prime256v1 (NIST P-256).

Generated separate CAs for Keyserver and Keyless client certificates. Generated ECDSA and RSA certs to test each cipher suite. Corralled all certificates and keys into testing/ directory.

jgrahamc commented 10 years ago

I had to revert this pull request because... it doesn't build. It doesn't build because the committer committed unmerged conflicts.

See, for example the <<<<<< in testclient.c in this commit: https://github.com/cloudflare/keyless/commit/b3b7223e1c91e2efaac30f7f6c68f359ca4e4534

To prevent pollution of the master branch this I have rolled back to the previous commit that was successful and done a force update. Once the committer fixes the cipher-suites branch another pull request can be looked at.

This situation should not have occurred. If you are making a pull request (especially against the master branch) then the code must build and the test suite must pass. Please run make clean; make; make test before sending the pull request.

0xhaven commented 10 years ago

Apologies, when rebasing and squashing commits, this merge somehow got un-committed. I've submitted a new pull request here.