Completion of error handling

[elfring]

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• fprintf ⇒ write_pid
• malloc ⇒ set_get_payload_state

[jgrahamc]

Makes sense. Want to fix and make a PR?

[elfring]

I suggest to avoid ignorance of return values a bit more. Can you reopen this issue?

Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

[jgrahamc]

I reopened it. If you want to fix and make a PR I'll be happy to merge it, but I'm not planning on making major changes to the code.

[elfring]

How do you think about to improve static source code analysis also for your software?

Do you find information sources like the following useful?

• Article "A Reusable Aspect for Memory Allocation Checking"
• Document "Aspect-Oriented Software Development - An Introduction" by Johan Brichau and Theo D'Hondt
• Paper "On Typesafe Aspect Implementations in C++" by Daniel Lohmann and Olaf Spinczyk

[jgrahamc]

I'm interesting mostly in running code with good test suites. If you find problems with the code I would very much appreciate fixes and PRs.

[elfring]

How do you think about to delegate some software development tasks to other tools like "AspectC++"?

[jgrahamc]

We have no plans to change the way this piece of code was developed.

[elfring]

It can be one of your design choices to continue source code maintenance in the manual way completely. I would prefer to achieve benefits with aspect-oriented software development by dedicated tools.

[jgrahamc]

Fixed.

[elfring]

There are more update candidates left over.

Examples:

• flush_write
• load_private_keys
• write_log

[jgrahamc]

OK.

[jgrahamc]

Done.

[elfring]

Thanks for your small source code improvement.