search

cloudflare / keyless

Cloudflare's Keyless SSL Server Reference Implementation
Other
275 stars 79 forks source link

Data races in keyless #81

Closed dgryski closed 10 years ago

dgryski commented 10 years ago

The following patch to Makefile will build keyless with -fsanitize=thread. It demonstrates at one race with ctime()'s static buffers in kssl_helpers.c and a few races in testclient .

There are also reports from libuv and openssl, but I'm not sure if those are true races or just because I didn't built those libraries also with -fsanitize=thread. (Got a segfault when trying to run "make test").

https://gist.github.com/dgryski/28d40d8b52aff29a4533

jgrahamc commented 10 years ago

Many thanks. I've addressed the problems with ctime and gethostbyname.