KEY-56 - Checkout do_ssl_handshake error and close if fatal

cloudflare / keyless

Cloudflare's Keyless SSL Server Reference Implementation

Other

275 stars 79 forks source link

KEY-56 - Checkout do_ssl_handshake error and close if fatal #93

Closed jgrahamc closed 9 years ago

jgrahamc commented 9 years ago

Previously, the first call to do_ssl_handshake was assume to 'work' (i.e. return WANT_READ or WANT_WRITE) and the error code was not checked. Added checking of the error code and if it is not retriable then drop the connection and log the error.

grittygrease commented 9 years ago

LGTM

PiotrSikora commented 9 years ago

Shouldn't we also add logging for the other do_ssl_handshake() call?

jgrahamc commented 9 years ago

Uh. Yes, we should. I thought it was being logged but alas the error is just being cleared and the connection terminated. I will update this pull request.

jgrahamc commented 9 years ago

Updated.

PiotrSikora commented 9 years ago

Looks good, feel free to merge it.