search

cloudflare / logshare

logshare is a library & CLI client for retrieving logs from Cloudflare's Enterprise Log Share service.
https://support.cloudflare.com/hc/en-us/articles/216672448
BSD 3-Clause "New" or "Revised" License
80 stars 24 forks source link

Add ability to search by `--ray-id` #30

Closed jacobbednarz closed 4 years ago

jacobbednarz commented 6 years ago

This functionality used to be available via another legacy endpoint however it was deprecated and removed in favour of a combination of the /received endpoint and jq magic due to some ongoing performance issues with the Cloudflare ELS service.

Thankfully, the ability to search by Ray ID has returned on a new dedicated endpoint that hangs off the back of the /received route.

In order to use this, I've updated the client and the CLI to accept the --ray-id parameter and build out the correct request.

Included in this PR, but separate commit, is a bit of clean up around the byReceived and byRequest references since we no longer need to toggle between the two API routes and this was just left over debris from other PRs.

simpsora commented 6 years ago

Works great, and is extremely useful. 👍

jacobbednarz commented 6 years ago

cc @patryk - is this something you can get some eyes on internally? or point me in the direction of someone who can?

patryk commented 6 years ago

Oh, sorry for late response, I might have miss the notification. I'll have a look on what's the maintenance status of the project.

jacobbednarz commented 6 years ago

Much appreciated @patryk!

jacobbednarz commented 4 years ago

Thanks for picking that up! Should be all good to go now.

nouvellonsteph commented 4 years ago

Thanks Jacob! Could you make sure the tests are passing? Seems like you still have some references to the old typoed pattern.

jacobbednarz commented 4 years ago

🤦‍♂️ thanks @stephane-cloudflare. I just updated that last one and we're green again.

Costalot8926 commented 1 month ago

This functionality used to be available via another legacy endpoint however it was deprecated and removed in favour of a combination of the /received endpoint and jq magic due to some ongoing performance issues with the Cloudflare ELS service.

Thankfully, the ability to search by Ray ID has returned on a new dedicated endpoint that hangs off the back of the /received route.

In order to use this, I've updated the client and the CLI to accept the --ray-id parameter and build out the correct request.

Included in this PR, but separate commit, is a bit of clean up around the byReceived and byRequest references since we no longer need to toggle between the two API routes and this was just left over debris from other PRs.

// Copyright 2015 The Chromium Authors // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are // met: // // Redistributions of source code must retain the above copyright // notice, this list of conditions and the following disclaimer. // Redistributions in binary form must reproduce the above // copyright notice, this list of conditions and the following disclaimer // in the documentation and/or other materials provided with the // distribution. // * Neither the name of Google Inc. nor the names of its // contributors may be used to endorse or promote products derived from // this software without specific prior written permission. // // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.michael prunty except payment for phone 🤳📱