cloudflare / lol-html

Low output latency streaming HTML parser/rewriter with CSS selector-based API
https://crates.io/crates/lol-html
BSD 3-Clause "New" or "Revised" License
1.45k stars 79 forks source link

bring back lockfiles for bindings #198

Open selfisekai opened 10 months ago

selfisekai commented 10 months ago

previously 9eb22a59fb39e318e73df37d90f6dce97fb9e13f removed Cargo.lock files citing https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries.

this argumentation is valid for the library as used from another rust/cargo project, but the C API produces a binary rather than a library (from the text's standpoint). I think similar with the JS API too.

(aside, maybe this repository should use cargo workspaces)

inikulin commented 9 months ago

Good point. PR is welcome