Closed kikito closed 1 year ago
@utix can I ask you to review/merge this?
@curiositycasualty This is good for me, but I am not a maintainer of this project. @jdesgats can you merge this ? I can help to maintain this module if you need help. Don't hesitate to add me.
While this gets fixed on each luarock that has this problem, you can use a workaround on your own system by changing how git downloads stuff from github specifically. Luarocks uses git underneath, so this should work:
git config --global url."https://github".insteadOf git://github
Is it possible to get this merged? Looks like it's outstanding a while, but this PR fixes it
Is it possible to get this merged? Looks like it's outstanding a while, but this PR fixes it
Seems like we are waiting on @jdesgats
I have tried via Tobias Rohrle from Cloudflare. Looks like it is abandonned. So I have created a new entry on luarocks and ask to update the root entry
https://github.com/luarocks/luarocks/issues/1504
I will do my best to maintain it, help is welcome.
merged. Apologies folks, there was a problem in the project maintenance. We are not actively making changes to this library, but we are happy to review and merge changes as needed.
@maurizioabba Hi, I'm one of the luarocks.org maintainers. Will you upload the new rockspec to luarocks.org (see CLI example in the PR description), or are you willing to handover to @utix the maintenance of the luarocks.org entry? Thanks!
@hishamhm I don't have the luarock key for uploading the version, so I can't do that step. Can you provide me one / point out to a doc for obtaining one please?
We can't pass maintenance of something fetching from CF github space to someone who is not in the CF organization.
@maurizioabba it is a personal account from a previous cloudflare guy that was used to publish. The best is to create a cloudflare account on luarocks upload on it and ask @hishamhm to do the modification. I understand you cannot authorize external to interact with your repo, perhaps you can archive it, and a new version from community can live. Looks like there is a couple of person interested to maintain it.
a new version from community can live.
is there one out there? as long as there is a new version already up and running in a different repo, happy to 👍 on the change of link pointed to by luarock (as long as any information about CF is removed)
I have forked one here https://github.com/utix/lua-resty-cookie I can remove Cloudflare mention if you ask and just keep name of previous author as they put their personal email
@utix thank you. If you can update https://github.com/utix/lua-resty-cookie/blob/master/rockspecs/lua-resty-cookie-scm-1.rockspec to point to your version and not CF, happy to approve the movement
Done @maurizioabba if you agree please confirm to @hishamhm
@hishamhm looks good to me
@utix I will redirect the root manifest entry in the luarocks.org repository to your account. Thanks @maurizioabba !
thanks to you all folks for following up on this issue and, in particular, thanks to @utix for maintaining the project!
@utix your entry is in the LuaRocks root manifest now, so your latest 0.2.0 is the new default, as will be any new releases you push under your account.
Currently luarocks install lua-resty-cookie fails with this error:
This is happening because github is no longer supporting direct-linking to releases using the git:// protocol. The fix is easy - replace with https.
In order to fix this completely someone with the right Luarocks key should do:
Thanks and have a good day.