cloudflare / lua-resty-cookie

Lua library for HTTP cookie manipulations for OpenResty/ngx_lua
347 stars 160 forks source link

Cannot install via Docker #54

Closed acoyfellow closed 1 year ago

acoyfellow commented 1 year ago

Hi there, thank you for this library, I have been using it for years with rock solid reliability.

I'm running into a new issue that has me somewhat baffled, I'm not sure where else to go.

When running "docker build", I'm hitting an error when it comes to installing lua-resty-cookie:

Installing https://luarocks.org/lua-resty-cookie-0.1.0-1.rockspec
Cloning into 'lua-resty-cookie'...
fatal: unable to connect to github.com:
github.com[0: 140.82.112.3]: errno=Connection timed out

Error: Failed cloning git repository.

I'm seeing this problem when working from a DigitalOcean droplet (2 different ones).

Stripped down Dockerfile:

FROM openresty/openresty:bionic

RUN apt-get update

RUN apt-get install git -y

RUN /usr/local/openresty/luajit/bin/luarocks install lua-resty-http \
    && /usr/local/openresty/luajit/bin/luarocks install lua-resty-auto-ssl \
    && /usr/local/openresty/luajit/bin/luarocks install lua-resty-template \
    && /usr/local/openresty/luajit/bin/luarocks install lua-resty-cookie \
    && /usr/local/openresty/luajit/bin/luarocks install web_sanitize

RUN openssl req -new -newkey rsa:2048 -days 3650 -nodes -x509 -subj '/CN=sni-support-required-for-valid-ssl' -keyout /etc/ssl/resty-auto-ssl-fallback.key -out /etc/ssl/resty-auto-ssl-fallback.crt

ADD ssl /etc/ssl

ADD templates /usr/local/openresty/nginx/html/templates

ADD static /usr/local/openresty/nginx/

ADD blocks /usr/local/openresty/nginx/html/templates

ADD confs /usr/local/openresty/nginx/conf

EXPOSE 8080
ENTRYPOINT ["/usr/local/openresty/nginx/sbin/nginx", "-g", "daemon off;"]

Does anyone have any insight or experience this issue? I woudln't be surprised if this was somehow my fault, but it feels like it popped up out of the blue.

Thanks,

[Edit]:

So, is the issue with the git repo URL within the .rockspec file? Or it is something else?

Edit2:

I didn't realize there is an open PR addressing this:

https://github.com/cloudflare/lua-resty-cookie/pull/50

acoyfellow commented 1 year ago

Adding this line to Dockerfile fixed it:

RUN git config --global url."https://github".insteadOf git://github