search

cloudflare / miniflare

🔥 Fully-local simulator for Cloudflare Workers. For the latest version, see https://github.com/cloudflare/workers-sdk/tree/main/packages/miniflare.
https://miniflare.dev
MIT License
3.78k stars 205 forks source link

[Miniflare 3] Mark WebSocket `fetch()` close test as flaky #620

Closed mrbbot closed 1 year ago

mrbbot commented 1 year ago

We're seeing this t.is(code, 3003) assertion flake quite a bit in CI. Instead of being 3003, the close code is 1006 which means "Abnormal Closure". I haven't been able to reproduce this locally, so suspect this is just some transient network failure with the Actions runner. Retrying the test seems to help, so this PR introduces a flaky helper for wrapping test implementations with. This retires a test 3 times.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 3ebdc925d6edaceece07f5248f9eddd2f108369b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/cloudflare/miniflare/new/bcoll/tre-allow-abnormal-closure?filename=.changeset/unlucky-boxes-march.md&value=---%0A%22%40fake-scope%2Ffake-pkg%22%3A%20patch%0A---%0A%0A%5BMiniflare%203%5D%20Allow%20abnormal%20closure%20in%20WebSocket%20%60fetch()%60%20test%0A)