search

cloudflare / miniflare

🔥 Fully-local simulator for Cloudflare Workers. For the latest version, see https://github.com/cloudflare/workers-sdk/tree/main/packages/miniflare.
https://miniflare.dev
MIT License
3.78k stars 205 forks source link

[Miniflare 3] Return copy of entry URL from `Miniflare#ready` #671

Closed mrbbot closed 1 year ago

mrbbot commented 1 year ago

Hey! 👋 There are cases where mutating the URL returned from Miniflare#ready may be desirable, e.g. changing the protocol to ws: and using the ws module to establish a WebSocket connection. Previously, doing this would break Miniflare's dispatchFetch, as the returned URL was Miniflare's own internal reference. This change makes sure we return a copy.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: db066c5ad85ec32abb97e4d1c635da93986ba67e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR