search

cloudflare / miniflare

🔥 Fully-local simulator for Cloudflare Workers. For the latest version, see https://github.com/cloudflare/workers-sdk/tree/main/packages/miniflare.
https://miniflare.dev
MIT License
3.78k stars 205 forks source link

[Miniflare 3] Remove unused `handleQueue()` function from entry worker #678

Closed mrbbot closed 1 year ago

mrbbot commented 1 year ago

With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker.

Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: f4ecf45ae82410b5a6f9e19173de657782d090e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/cloudflare/miniflare/new/bcoll/tre-removed-unused-queues-code?filename=.changeset/tricky-fireants-leave.md&value=---%0A%22%40fake-scope%2Ffake-pkg%22%3A%20patch%0A---%0A%0A%5BMiniflare%203%5D%20Remove%20unused%20%60handleQueue()%60%20function%20from%20entry%20worker%0A)

mrbbot commented 1 year ago

@petebacondarwin exactly, this code has been moved here: 👍 https://github.com/cloudflare/miniflare/blob/d1f1ef71fab921b44018c927eb25412218fb028b/packages/miniflare/src/workers/queues/broker.worker.ts#L190-L209