cloudflare / miniflare

🔥 Fully-local simulator for Cloudflare Workers. For the latest version, see https://github.com/cloudflare/workers-sdk/tree/main/packages/miniflare.
https://miniflare.dev
MIT License
3.78k stars 205 forks source link

[Miniflare 3] Fix `KVNamespace#put()` with empty value #704

Closed mrbbot closed 1 year ago

mrbbot commented 1 year ago

Empty put()s may send HTTP requests with null bodies, violating an assumption we had. This change handles this case, and adds some additional tests for empty values.

Closes #703

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 4191b32ec213f5c213b751cd986f4c8895ad830b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/cloudflare/miniflare/new/bcoll/tre-fix-empty-kv-put?filename=.changeset/fresh-panthers-raise.md&value=---%0A%22%40fake-scope%2Ffake-pkg%22%3A%20patch%0A---%0A%0A%5BMiniflare%203%5D%20Fix%20%60KVNamespace%23put()%60%20with%20empty%20value%0A)