search

cloudflare / miniflare

🔥 Fully-local simulator for Cloudflare Workers. For the latest version, see https://github.com/cloudflare/workers-sdk/tree/main/packages/miniflare.
https://miniflare.dev
MIT License
3.78k stars 205 forks source link

fix: unhandled error thrown by busboy #711

Closed b-marques closed 1 year ago

b-marques commented 1 year ago

As per, https://fetch.spec.whatwg.org/#dom-body-formdata, TypeErrors are expected to be thrown. Busboy errors were being unhandled.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: b84e8d141b4da8724de775518d6903e4b50b9116

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

b-marques commented 1 year ago

Sorry about the forced-push, this commit: https://github.com/cloudflare/miniflare/pull/711/commits/6c71c73f70b504cf66baeeac0b91b59e37f1c0ac, was a missclick from my side :/

Had to add some missing fix

b-marques commented 1 year ago

@mrbbot FYI, from Nodejs v16.19.0 onwards, the undici is included with the multipart/form-data parser.

mrbbot commented 1 year ago

The test failures seem to be caused by CI now using Node 21. I can fix those in a separate PR. If you fix that throwsAsync() issue, I'll get this merged. 👍

mrbbot commented 9 months ago

Hey! 👋 Apologies for the delay, but this has now been released as part of miniflare@2.14.2. 👍