cloudflare / miniflare

🔥 Fully-local simulator for Cloudflare Workers. For the latest version, see https://github.com/cloudflare/workers-sdk/tree/main/packages/miniflare.
https://miniflare.dev
MIT License
3.78k stars 205 forks source link

Increase better-sqlite3 compatibility #751

Closed stephtr closed 10 months ago

stephtr commented 10 months ago

Is it possible to bump the better-sqlite3 requirement of @miniflare/shared to 9.x.x? There are some issues with better-sqlite3@8.x.x on Node 20 (most recent LTS), see https://github.com/WiseLibs/better-sqlite3/pull/1100 or https://github.com/WiseLibs/better-sqlite3/issues/1027, while I didn't notice any adverse effects when upgrading to 9.x.x. The only breaking change should be drop of official support for Node 16, which is EOL.

mrbbot commented 10 months ago

Hey! 👋 Thanks for raising this. Unfortunately, as better-sqlite3@9.0.0 drops support for Node 16, upgrading to this would be a semver major breaking change for Miniflare 2. Considering we're planning to deprecate Miniflare 2 soon once we have support for the Vitest unit testing environment in version 3, I don't think we'll do this. I'd encourage you to migrate to Miniflare 3 if you can.