Eetom/frontend style - Githubissues

cloudflare / mitm.watch

MIT License

14 stars 4 forks source link

Eetom/frontend style #1

Closed eetom closed 6 years ago

eetom commented 6 years ago

For Review:

I'm using a bunch of placeholder code to simulate what the table and warning will look like.

here is a screenshot.

Feedback welcome! I'll remove the excess code prior to approve/merge.

eetom commented 6 years ago

Table will have to have overflow for mobile/smaller screen views.

eetom commented 6 years ago

Removed excess testing code
Added back the footer
Responsiveness fixed

Ready for review @Lekensteyn

Lekensteyn commented 6 years ago

I just tested it, it looks nice and clean. One bug: if the screen is resized to a smaller size, the footer is sticky to the bottom. When scrolling the page down, the footer moves up.

Though for now, this is a minor issue as mobile browsers are not yet supported by this test (which relies on Flash).

Lekensteyn commented 6 years ago

Thanks @eetom for the PR, I have applied it and also fixed the footer issue in 34d07b117464128e57976ea16199855547cc5cf6 (it would appear whenever the height it smaller, e.g. when devtools are open).

(Tested in Chrome only though)