cloudflare / mitmengine

A MITM (monster-in-the-middle) detection tool. Used to build MALCOLM:
https://malcolm.cloudflare.com
BSD 3-Clause "New" or "Revised" License
799 stars 68 forks source link

Minor change to mergedb to no longer merge over OS version #5

Closed gabbifish closed 5 years ago

gabbifish commented 5 years ago

Hi there! This is a tiny PR :) I noticed that we were merging over operating system version, which often produces large fingerprints. Given that operating systems and their cryptography can often substantially vary across versions, I thought it would be useful to not merge fingerprints over operating system versions to maintain some granularity in their fingerprints.

Let me know what you think. With the changes I made here, our merged new fingerprints still continued to pass the tests I wrote in #4.