Closed justinasfour04 closed 4 years ago
That's unfortunate. It definitely worked when I implemented it.
I've added this to my todo list.
@terinjokes Is this PR going to get updated #54 ?
I'm unsure, I'll be able to take a look this weekend.
@terinjokes we are at a fork in road here, we believe in OSS and love this lib but if it cannot be maintained a little more we will use the cloudflare API directly as it is a current blocker.
With that said how do you feel about adding @justinasfour04 (or someone else) as a maintainer of this lib and making it more of a communal effort, considering it is not an official Cloudflare product?
I started working on this over the weekend. Unfortunately, I ran out of time before completing it. I plan on continuing this week.
Thanks @terinjokes
Just out of curiosity why did you not answer the question that @naseemkullah asked about adding on more maintainers to the project? If you do not have time to keep the project maintained and teams from around the world need it then why not ask for help?
Pull requests are accepted, but at this time I don't plan on adding additional maintainers. I suspect this will change in the future.
I removed this library from my project and got
works. Not sure what the status is on the fix but for now you lost a developer using this library
This is being removed in the next version, 3.0.0 which you can track in the 3.0.0 milestone
oh nice ok. I'll keep my eye out
Can someone encountering this issue, and still using this library, take a look at the fix proposed in #67 and confirm it works in their environment?
Hey folks, any change we could get some traction on this? It causes us quite a bit of pain. Alex has done the work in the PR and tested it on our apps that use this library at AutoTrader, i'm not sure what else we need to do?
I removed this library from my project and
got
works. Not sure what the status is on the fix but for now you lost a developer using this library
Just to clarify, we no longer use the lib and are not planning to go back for the time being, as such we are no longer in a place to comment about it.
We are using cloudflare-node version 2.7.0 and cannot use got due to the related issue. cloudflare has a dependency that needs updating cloudflare@2.7.0 └─┬ https-proxy-agent@2.2.4 └── agent-base@4.3.0
related issue: https://github.com/sindresorhus/got/issues/1039