add odoh accept header, log cli errors, make domains fqdns

cloudflare / odoh-client-go

Oblivious DoH client

MIT License

80 stars 19 forks source link

add odoh accept header, log cli errors, make domains fqdns #11

Closed kimbo closed 3 years ago

kimbo commented 3 years ago

Summary of changes:

added Accept: application/oblivious-dns-message HTTP header to odoh client. I know it's still a draft, but that's what it says clients SHOULD do (see section 4.1).
log errors returned from app.Run()
automatically make domains fqdns

I also did a bit of code cleanup, mostly involving stuff in commands/common.go and changing errors.New(fmt.Sprintf()) to fmt.Errorf() in commands/request.go.

kimbo commented 3 years ago

@chris-wood bump

chris-wood commented 3 years ago

Hey @kimbo -- thanks for filing this! It's in my queue to review. I will follow back here ASAP. :-)