search

cloudflare / pages-action

MIT License
440 stars 91 forks source link

replace deprecated 'publish' with 'deploy' #101

Open CyberFlameGO opened 10 months ago

barrenechea commented 8 months ago

@WalshyDev @GregBrimble could you consider reviewing/merging this PR? I appreciate any help you can provide.

jasikpark commented 8 months ago 
Run cloudflare/pages-action@v1.5.0
npm WARN exec The following package was not found and will be installed: wrangler@2.20.1
npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
Delegating to locally-installed wrangler@3.15.0 over global wrangler@2.20.1...
Run `npx wrangler pages publish dist --project-name=www-defined --branch=update-deploy-script` to use the local version directly.

▲ [WARNING] `wrangler pages publish` is deprecated and will be removed in the next major version.

  Please use `wrangler pages deploy` instead, which accepts exactly the same arguments.

✨ Compiled Worker successfully
Uploading... (641/644)
Uploading... (642/644)
Uploading... (643/644)
Uploading... (644/644)
✨ Success! Uploaded 3 files (641 already uploaded) (1.66 sec)

✨ Uploading _headers
✨ Uploading _redirects
✨ Uploading Functions bundle

I'd love to eliminate this deprecation warning in my deploy logs

albbus-stack commented 2 months ago

Same as #118 this also fails to comply to a deprecation warning, this time an internal one from wrangler itself. This needs to be merged 😟