search

cloudflare / pages-action

MIT License
440 stars 91 forks source link

Update README GITHUB_TOKEN to DEPLOY_TOKEN #111

Closed socketopp closed 6 months ago

socketopp commented 6 months ago 
gitHubToken: ${{ secrets.GITHUB_TOKEN }}

Result in

 Failed to add secret. Secret names must not start with GITHUB_.

GITHUB_TOKEN is not a valid name so I suggest the README.md is updated. Better name would be DEPLOY_TOKEN

See more: https://github.com/github/docs/pull/12095

WalshyDev commented 6 months ago

GITHUB_TOKEN is actually correct per the last comment in that linked issue - https://github.com/github/docs/pull/12095#issuecomment-974285693

and the associated docs: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret

There's no manual work needed to add this token, it's automatically available to all GitHub workflows.