search

cloudflare / pages-action

MIT License
440 stars 91 forks source link

Fix nodejs deprecated warning #118

Open riderx opened 5 months ago

riderx commented 5 months ago

This Pr fix the issue about deprecated warning reference from https://github.com/cloudflare/pages-action/issues/117

cagataygurturk commented 5 months ago

Any ETA for its release?

andykenward commented 3 months ago

@riderx can we also update the build cli esbuild target from es2021 to node20?

From

https://github.com/cloudflare/pages-action/blob/aeb0d936a7e08b4861c3d0ac8811fe39138085f9/package.json#L7

To

"build": "npx esbuild src/index.ts --bundle --platform=node --target=node20 --outfile=index.js",
albbus-stack commented 2 months ago

This is not that big of a deal and it should have been already merged to comply with the deprecation 😢

benminer commented 3 weeks ago

Any reason this hasn't been merged yet?

Fabio1988 commented 1 week ago

what's the blocker of this?

riderx commented 1 week ago

Thanks @andykenward i modified it! I'm not a core contributor, so I cannot do much more than a PR

riderx commented 1 week ago

Maybe @WalshyDev if you can report internally it, it would be super nice <3

WalshyDev commented 1 week ago

cc: @cloudflare/banda-team

andykenward commented 1 week ago

Also need to update @types/node to 20. Plus we can remove the usage of the NPM package "undici" for fetch as Node.js 20 supports fetch natively.

https://nodejs.org/docs/latest-v20.x/api/globals.html#fetch