search

cloudflare / pages-action

MIT License
473 stars 97 forks source link

Add support for specifying branch #19

Closed spencerreeves closed 2 years ago

spencerreeves commented 2 years ago

As a user, I would like to provide my own logic to determine which deployments go to production and which go to preview. Adding support to specify the branch name gives me that flexibility since the branch name is used by Cloudflare Pages to determine if the deployment is production or preview.

In this PR, we have added the parameter branch that is passed directly to wranger2. Wrangler2 handles the situation when the branch is empty, so no additional checks are needed.

Since this is an optional parameter, documentation is added as an aside.

This closes https://github.com/cloudflare/pages-action/issues/11 https://github.com/cloudflare/pages-action/issues/12

forforeach commented 2 years ago

Is there any chance this would be merged soon? There is a couple of issues and PRs that are regarding the same issue with the branch specification.

WalshyDev commented 2 years ago

This is looking good from a quick look, will do a proper review tomorrow

Thank you very much for the PR and apologies for not seeing it earlier :)