search

cloudflare / pages-action

🛑 DEPRECATED, please use wrangler-action
MIT License
476 stars 101 forks source link

Handle `pull_request` events better #22

Closed RichiCoder1 closed 1 year ago

RichiCoder1 commented 2 years ago

Right now, Cloudflare's default behaviors for pull_request events are kinda wonky. Because PR events are against a merged commit and this action assumes push events, it's reporting HEAD for the current branch and it also isn't reporting the correct commit to the GitHub Deployments API which results in deployments not showing up on their appropriate PR.

Willing to contribute fixes for both of these.

olup commented 2 years ago

I'll be super interested for a fix on this. Is there a fork already ?