Closed andersk closed 1 year ago
Same issue here.
The line 28 of README should point to the last tag available for this action.
From:
uses: cloudflare/pages-action@1
To (at the time of commenting this issue):
uses: cloudflare/pages-action@v1.2.0
Thanks!
@gonzaleztroyano No, it is correct for the README to refer to the major release tag 1
. This tag should just be repointed in Git to the latest v1.x.x
release whenever a release is made. That lets users run the latest compatible release without manually updating their workflow files every time. See About custom actions § Using tags for release management.
Awesome! Thanks for the info, @andersk! Now I understand that the README is correct but it is the "internal pointer" which should be pointed to the newer version. 🙃🙃
The 1
tag still points to the same commit as 1.1.0
and v1.1.0
(and there is no v1
tag). Please reopen.
There hasn't been a release yet.
There was v1.2.0
. The 1
tag still points to v1.1.0
.
(I understand that if there’s a future v1.3.0
, this action will theoretically create v1
pointing to v1.3.0
. But even that’s not going to fix this, because 1
≠ v1
, 1
is what’s documented in README.md
and used by existing users, and 1
will still point to v1.1.0
. In any case, why wait for v1.3.0
when you can fix this now by simply repointing a tag?)
Release has been done. 1.3.0 now points to v1
and 1
. As stated in the release, the 1
tag is considered deprecated now. Please change to v1
The
1
tag still points to the same commit as1.1.0
andv1.1.0
, so users writinguses: cloudflare/pages-action@1
as documented are still getting the version with theset-output
deprecation warning. The tag needs to be repointed tov1.2.0
.