Closed aaronadamsCA closed 4 weeks ago
@aaronadamsCA Thanks for your suggestion! We're working on deprecating this repo, and moving everything to wrangler-action. We're tracking deployments support here, although I'm not sure yet that we'll be switching to opt-out vs opt-in.
That's great @nprogers, I'll close this and add a note over there that (whether opt-in or opt-out) the deployment feature should be controlled using a boolean, since actions can always access github.token
.
To enable GitHub deployments and deployment statuses today, you need to pass in your GitHub token manually:
IMO this is a bad API for a few reasons:
gitHubToken
doesn't match the behaviour "enable GitHub deployments".github.token
.I'd like to suggest the following changes:
gitHubToken
to${{ github.token }}
. The user would only need to setgitHubToken
if for some reason they wanted to use a different token.createDeploymentStatus
, optional, default valuetrue
.With these changes, a subset of users could still disable deployment statuses or override the GitHub token, but everyone else would benefit from simpler setup with more default features.
I'm happy to contribute this change if it's desired. I expect it would require a major version bump.