search

cloudflare / pingora

A library for building fast, reliable and evolvable network services.
Apache License 2.0
21.42k stars 1.18k forks source link

fix `cargo run --example server`, missing cert #116

Closed yshing closed 5 months ago

yshing commented 7 months ago

Running cargo run --example server throws an error caused by missing the pingora/test/keys folder.

This PR copies the cert from the pandora-core folder, so the example runs out of the box.

Hopefully, this will save a few minutes for the next person trying to run cargo run --example server right after cloning.

gitguardian[bot] commented 7 months ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

andrewhavck commented 6 months ago

This PR copies the cert from the pandora-core folder, so the example runs out of the box.

Mind using a symlink instead?

yshing commented 6 months ago

Hey @andrewhavck updated.

drcaramelsyrup commented 5 months ago

Thanks for contributing! This was merged in 7ce6f4ac1c440756a63b0766f72dbeca25c6fc94.