Only compile pingora-openssl and its deps when openssl is enabled.

cloudflare / pingora

A library for building fast, reliable and evolvable network services.

Apache License 2.0

20.3k stars 1.1k forks source link

Only compile pingora-openssl and its deps when openssl is enabled. #131

Closed samurai00 closed 3 months ago

samurai00 commented 3 months ago

Enabling boringssl should only compile pingora-boringssl but pingora-openssl still gets compiled. This is not what I expected.

This PR fixes this issue by updating the Cargo.toml files for several crates to set default-features to false. This ensures that the openssl feature of pingora-core and its dependency pingora-openssl are only depended on when the openssl feature is enabled.

andrewhavck commented 3 months ago

This has been merged, thanks!