In multiple places in the code, String or &str are used for specifying paths, instead of OsStr or Path or other similar types.
Examples include:
ServerConf fields error_log, ca_file
Opt field conf
Listeners methods add_tls and add_uds
In most cases, paths are not required to be valid UTF-8.
It would be good to switch to use the correct types for these interfaces, or use a crate like camino and explicitly document that pingora only works with UTF-8 paths.
In multiple places in the code,
Stringor&strare used for specifying paths, instead ofOsStrorPathor other similar types.Examples include:
ServerConffieldserror_log,ca_fileOptfieldconfListenersmethodsadd_tlsandadd_udsIn most cases, paths are not required to be valid UTF-8.
It would be good to switch to use the correct types for these interfaces, or use a crate like
caminoand explicitly document thatpingoraonly works withUTF-8paths.